Skip to content

fix: resolve eslint config ignores for agent skills and fix ts/lint v… - #3

Merged
ivancidev merged 2 commits into
mainfrom
feat/dashboard-chat-usability
Jul 20, 2026
Merged

fix: resolve eslint config ignores for agent skills and fix ts/lint v…#3
ivancidev merged 2 commits into
mainfrom
feat/dashboard-chat-usability

Conversation

@ivancidev

Copy link
Copy Markdown
Owner

…alidation issues

📌 Descripción

Describa los cambios principales introducidos en este Pull Request y qué problema resuelven.

🧪 Pruebas realizadas

Detalle los pasos para verificar los cambios localmente:

  • ¿Se ejecutó bun run lint exitosamente?
  • ¿Se ejecutó bun run build exitosamente?
  • Pasos de pruebas manuales realizados:

📸 Capturas de pantalla o grabaciones (si aplica)

Adjunte capturas o grabaciones para cambios de interfaz de usuario.

📋 Lista de verificación

  • Mi código sigue el estilo y arquitectura del proyecto (AGENTS.md).
  • He actualizado la documentación correspondiente si aplica.
  • No he expuesto claves API ni información sensible en código o commits.

@ivancidev ivancidev self-assigned this Jul 20, 2026
Copilot AI review requested due to automatic review settings July 20, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
skillstudio Ready Ready Preview, Comment Jul 20, 2026 8:48pm

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix ESLint ignores for .agents and resolve TS/lint issues in pages

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Ignore ".agents/" in ESLint to prevent agent-skill artifacts from breaking lint.
• Tighten dashboard sort handler typing to satisfy TypeScript and lint rules.
• Remove unused lucide-react icon imports to clear lint warnings.
Diagram

graph TD
  A["Developer runs lint"] --> B["eslint.config.mjs"] --> C["ESLint file discovery"] --> D["Ignore .agents/**"] --> E["Lint app pages"] --> F["Clean TS/lint results"]
  E --> G["app/(app)/dashboard/page.tsx"]
  E --> H["app/(marketing)/page.tsx"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use ESLint overrides for .agents instead of global ignore
  • ➕ Allows selectively relaxing rules rather than skipping the directory entirely
  • ➕ Better if some .agents content should still be linted/typed
  • ➖ More config complexity and ongoing maintenance
  • ➖ Doesn’t help if the directory is purely generated and noisy
2. Relocate/generated artifacts outside repo or into build output
  • ➕ Avoids tooling exceptions and accidental commits
  • ➕ Keeps source tree clean and reduces editor/tooling overhead
  • ➖ May not fit current agent workflow expectations
  • ➖ Could require updates to scripts/docs and developer setup

Recommendation: Keeping a simple ignore for .agents/** is a pragmatic fix if that directory is generated/auxiliary and not intended to be linted. If .agents is meant to contain maintained source, consider an override-based approach so issues still surface without breaking the main lint pipeline.

Files changed (3) +2 / -3

Bug fix (2) +1 / -3
page.tsxTighten sortBy onChange typing to a concrete union +1/-1

Tighten sortBy onChange typing to a concrete union

• Replaces an unsafe cast (as any) with a strict union type for sort selection ('newest' | 'oldest' | 'name'), addressing TS/lint validation complaints while preserving behavior.

app/(app)/dashboard/page.tsx

page.tsxRemove unused lucide-react icon imports +0/-2

Remove unused lucide-react icon imports

• Drops unused ShieldCheck and ArrowRight imports to eliminate lint warnings and reduce dead code in the marketing page module.

app/(marketing)/page.tsx

Other (1) +1 / -0
eslint.config.mjsIgnore .agents directory in ESLint +1/-0

Ignore .agents directory in ESLint

• Adds .agents/** to the global ignore list so agent-skill artifacts don't participate in lint runs and fail validation.

eslint.config.mjs

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

…e audit

Vendors the design-taste-frontend skill (MIT, Leonxlnx/taste-skill) into
.agents/skills/, then applies its landing-page rules to the marketing page:
split hero with a real /generate screenshot instead of a fake div mockup,
removed version-label badge, deduped repeated CTAs, broke up the equal
3-column feature grid, trimmed hero copy under the word cap, added a
closing CTA section, and replaced em-dashes across visible strings.
@ivancidev
ivancidev merged commit 6e803c5 into main Jul 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants