feat: telescope preview - #305
Open
xieyonn wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
remove require("telescope").setup({
extensions = {
fidget = {
previewer = false,
wrap_text = false,
},
},
}) |
xieyonn
force-pushed
the
feat/telescope-preview
branch
2 times, most recently
from
January 28, 2026 12:15
b7316ef to
4732b1c
Compare
1. Remove deprecated function `vim.api.nvim_buf_add_highlight`, add a
helper buf builder.
2. Add missing annotation style.
2. Use a global variable _G.__fidget_telescope_config is not a good
design, and we do not need either.
3. Not need a option `use_previewer`, a option in `previewer = false` in
telescope config will just work. Which allow you disable previewer by
default, but you can still toggle previewer window.
eg:
disable preview by default.
```lua
require("telescope").setup({
extensions = {
fidget = {
previewer = false,
},
},
})
```
or in lua api
```lua
require("telescope").extensions.fidget.fidget({ previewer = false })
```
xieyonn
force-pushed
the
feat/telescope-preview
branch
from
January 30, 2026 05:18
4732b1c to
d0f84d3
Compare
Contributor
|
Instead of adding a new file (buf.lua) in core, wouldn't it make sense to group any code related to telescope in the telescope extension directory? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vim.api.nvim_buf_add_highlight, add a helper buf builder._G.__fidget_telescope_configis not a good design, and we do not need either.use_previewerbecause setpreviewer = falsein telescope config will just work.eg:
disable previewer by default, but you can still toggle previewer window.
or in telescope extension config.
before:

after:
