fix(ui): true menu X and hide Cached tile on mobile - #31
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
tokentally | cc3d39b | Aug 06 2026, 12:04 PM |
jackmcpickle
marked this pull request as ready for review
August 6, 2026 11:58
Replace the SVG bar morph with positioned spans so the open state is a centered X, and force-hide the Cached stat tile on small screens so Button's inline-flex utility cannot override it. Co-authored-by: Jack McNicol <jackmcpickle@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/mobile-nav-filters-1d85
branch
from
August 6, 2026 12:04
f47d8b0 to
cc3d39b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #30 (already on
main):sm. Button’s Tailwindinline-flexwas winning over the previousdisplay: none, so Cached still appeared on phones.Rebased onto latest
main(post-#30); only this follow-up commit remains.Screenshots
Mobile leaderboard with four stats (Cached hidden)
Mobile nav open with centered X icon
Test plan
pnpm check(358 tests)origin/mainsm+): Cached returns in the five-metric rowTo show artifacts inline, enable in settings.