chore: enable workers.dev/preview URLs and update packages - #32
Merged
Conversation
Custom domain routes were inferring workers_dev=false (and disabling preview URLs). Explicitly enable both, and update npm packages to latest. Co-authored-by: Jack McNicol <jackmcpickle@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
tokentally | ef9b3fa | Aug 06 2026, 01:34 PM |
jackmcpickle
marked this pull request as ready for review
August 6, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workers_dev: trueandpreview_urls: trueinwrangler.jsoncso custom domain routes no longer disable the*.workers.devsubdomain and version preview URLs.hono4.13.0,wrangler4.119.0,@cloudflare/workers-types,oxlint,oxfmt, etc.).Why
With custom domains configured under
routes, Wrangler infersworkers_dev = false, which also disables preview URLs by default. This restores both for preview deploys (pnpm deploy:preview/ versions upload).Test plan
pnpm checkpasses (lint, fmt, typecheck, 358 tests)workers_devandpreview_urls*.workers.devand version preview URLs are available in the Cloudflare dashboard