Phase 1: engineering foundation - #2
Open
jameshoweee wants to merge 1 commit into
Open
Conversation
- pyproject.toml replacing requirements.txt (Python >=3.10, scipy >=1.11, numpy >=1.24, pandas >=2.0, pytest + mpmath as dev) - Pytest test suite: 82 parametrized tests from generated vectors (good/bad/mediocre), plus table lint via mpmath recomputation - GitHub Actions CI: matrix on Python 3.10/3.12, generates vectors on the fly, no large testdata download needed - Table lint (test_tables.py): recomputes half-Gaussian PDT/CDT at 400-bit precision with mpmath, verifies Python and C tables match — deterministic detector for table errors like the Phase 0 PDT/RCDT confusion - Structured output: to_dict()/to_json() on UnivariateSamples and MultivariateSamples for machine-readable results - Configurable params: tau, chi2_bucket, pmin are now constructor args with defaults, no longer module-level globals - Fixed doornik_hansen rank-deficient path (column projection + index reset so dot products align) - Cleaned up unused imports from test_rejind removal - .gitignore for __pycache__, test_vectors, .eps, .pytest_cache
Owner
Author
|
consolidating into a single PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the project setup so we can actually run things reliably:
pyproject.tomlreplacesrequirements.txt— Python >=3.10, proper depstest_tables.py: lint PDT/RCDT tables against mpmath at 400-bit precision (tolerance 100 for rounding).gitignorefor pycache, test_vectors, .pytest_cache, etcsaga.py: addedto_dict(),to_json(),effect_sizes()for programmatic access, made tau/chi2_bucket/pmin constructor params