feat(web): carry cohesive request aggregates across server functions - #954
feat(web): carry cohesive request aggregates across server functions#954mdorman wants to merge 13 commits into
Conversation
| subscription_id, | ||
| }; | ||
| let remove_request = request.clone(); | ||
| let submit_remove = move |event: leptos::ev::SubmitEvent| { |
There was a problem hiding this comment.
Can these helpers be extracted and unit tested? I know we've done that with some things that strike me as similar.
There was a problem hiding this comment.
Yes. Updated in 299a657: both membership forms now delegate pending/dedup and payload dispatch to the existing host-tested forms::request_submit_gate; MemberToggle retains only the SubmitEvent adapter and operation-specific request construction.
| source: item.source, | ||
| force: Some(true), | ||
| }; | ||
| let submit = move |event: leptos::ev::SubmitEvent| { |
There was a problem hiding this comment.
Similarly, can this become a host-tested helper?
There was a problem hiding this comment.
Yes. Updated in 299a657: ordinary and forced delete now use the same host-tested forms::request_submit_gate. The component closures only prevent native submission and invoke the tested callback; the ordinary-delete callback also atomically records its target with dispatch.
Proof: - devtool run -- devtool pg run -- cargo nextest run -p jaunder web::web_auth - devtool run -- cargo xtask e2e-local auth.spec.ts - devtool run -- cargo xtask check
299a657 to
b6fa5d7
Compare
1 participant
Summary
Verification
cargo xtask validateCloses #417