Replace ZippyJSON with Foundation's JSONDecoder - #80
Open
jbuckner wants to merge 1 commit into
Open
Conversation
JSONDecoder is faster than ZippyJSON on iOS 17+ per ZippyJSON's own README, and this is a read-only API client with no hot-loop decoding below that. Drops the C++ simdjson dependency, which also unblocks half of the WASM path for #27. Full suite green on the Foundation decoder, including the snake_case regression tests. Closes #29 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 13 13
Lines 686 686
=======================================
Hits 631 631
Misses 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29. Went with option C (drop unconditionally): the floor moves to iOS 15 in #59 anyway, the example app is iOS 17, and this client has no hot-loop decoding. Merge order note: conflicts trivially with the other InternetArchive.swift PRs on the decoder property lines; whichever lands last needs a quick main merge.
🤖 Generated with Claude Code
https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf