Switch from SwiftLint to swift-format - #81
Open
jbuckner wants to merge 1 commit into
Open
Conversation
Adds .swift-format (lineLength 120, 2-space indent), swaps the CI lint job for swift format lint --strict, drops .swiftlint.yml, and applies the one-time format pass (trailing whitespace only). Closes #28 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+38
to
+44
| name: swift-format | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Run SwiftLint | ||
| run: swiftlint --reporter github-actions-logging | ||
| - name: Run swift-format lint | ||
| run: swift format lint --strict --recursive InternetArchiveKit |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 91.98% 92.12% +0.14%
==========================================
Files 13 13
Lines 686 686
==========================================
+ Hits 631 632 +1
+ Misses 55 54 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28. Two post-merge steps: (1) rename the required status check on main from SwiftLint to swift-format or PRs block on a check that never runs; (2) if you want a .git-blame-ignore-revs entry, add the squash SHA after merging (the reformat turned out to be trailing-whitespace only, so it may not be worth it). Merge this last; it'll need a quick main merge and format re-run after the other open PRs land.
🤖 Generated with Claude Code
https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf