Skip to content

Add IAS3 upload and file delete support - #89

Open
jbuckner wants to merge 1 commit into
s3-authfrom
ias3-upload
Open

Add IAS3 upload and file delete support#89
jbuckner wants to merge 1 commit into
s3-authfrom
ias3-upload

Conversation

@jbuckner

Copy link
Copy Markdown
Owner

Closes #85. Part of #35, stacked on #74 (auth); merge that first and this retargets to main. Note: the four write-API PRs (#86-#89) all add the same missingCredentials error case as identical hunks, so they merge cleanly in any order, but each will want a quick main merge as the others land.

🤖 Generated with Claude Code

https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf

upload() PUTs a file to s3.us.archive.org with the LOW header, covering
auto-make-bucket, queue-derive, size-hint, and x-archive-meta-* headers
(uri() encoding for non-ASCII values, double hyphens for underscores in
names). deleteFile() removes a file with cascade delete. S3 XML errors
surface their Message element. The body is held in memory, so this
suits normal-sized files rather than multi-gigabyte ones.

Closes #85

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.19588% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (56628ab) to head (cd8dbc3).

Files with missing lines Patch % Lines
InternetArchiveKit/InternetArchiveProtocols.swift 0.00% 21 Missing ⚠️
InternetArchiveKit/InternetArchive.swift 94.20% 4 Missing ⚠️
InternetArchiveKit/InternetArchiveErrors.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           s3-auth      #89      +/-   ##
===========================================
- Coverage    91.33%   89.31%   -2.03%     
===========================================
  Files           14       14              
  Lines          773      870      +97     
===========================================
+ Hits           706      777      +71     
- Misses          67       93      +26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant