Skip to content

[libgraphql-core] Rework approach to Errors #33

Description

@jeffmo

Right now libgraphql APIs emit errors of varying detail, with varying structure and error messages, and likely makes all future additions/changes/improvements to errors over time a breaking change.

This is because I’ve taken the shortcut of quickly building ad-hoc error variants as i build out the library — which means we’re thorough on expressing many different error cases; But the terminology used by error variants, display messages for them, and included details (eg some include lots of location info, some not enough) for each error variant is generally inconsistent.

Additionally, all error variants are exhaustive — which means adding new errors over time is technically a breaking change to any consumers that match on the previously-exhaustive set of errors.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1.0-blockingIssue that must be resolved before shipping v1.0

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions