chore(apple): rename the macOS app bundle from Pilot.app to Cockpit.app - #247
Merged
Conversation
Set productName/PRODUCT_NAME to Cockpit on the Pilot target so the built bundle and executable are Cockpit.app / Cockpit, matching the marketing name already used in Info.plist. PRODUCT_MODULE_NAME stays Pilot so the Swift module, target, scheme, sources, tests, bundle identifier, and the Application Support/Pilot data directory are unchanged. CEF resolves helpers as "<main executable> Helper.app", so the executable rename would have broken the embedded browser. The helper names are locked in cef-artifacts.json (byte-compared against the published immutable runtime), so instead of renaming them ChromiumKit now passes the manifest's base helper to CEF explicitly via browser_subprocess_path and fails early with a clear error if it is missing. Update every script, workflow, and doc path that named Pilot.app, and the capture script's process/window name. Verified: Chromium-configuration ChromiumRealEngineSmokeTests (renderer and GPU helpers launch under Cockpit.app), a Debug build of the Pilot scheme, and bin/check-docs.sh. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joeblau
force-pushed
the
chore/rename-pilot-app-to-cockpit
branch
from
August 28, 2026 16:14
c422c04 to
9204519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productName/PRODUCT_NAME: Cockpiton thePilottarget so the built bundle isCockpit.appwith executableCockpit;PRODUCT_MODULE_NAMEstaysPilotso the Swift module, target, scheme, sources, tests, bundle ID, andApplication Support/Pilotdata directory are untouched.<main executable> Helper.app, and the helper names are locked incef-artifacts.json(byte-compared against the published immutable runtime, so renaming them means a new ChromiumKit release). ChromiumKit now passes the manifest's base helper to CEF explicitly viabrowser_subprocess_path, with an early error if it is missing. Documented indocs/chromium-browser.md.Pilot.app(capture-pilot.sh,install-pilot-chromium.shdefault destination now/Applications/Cockpit.app,validate-chromium-archive.sh,ci.yml,apple-release.yml,chromiumkit-bootstrap.yml,package.jsoncockpitscript, ChromiumKit README).Verification
ChromiumRealEngineSmokeTests(asserts renderer and GPU helpers launch) — passed, hosted byCockpit.app.Pilotscheme — producesCockpit.appwithCFBundleExecutable = Cockpit.bin/check-docs.sh— passed.Note
Sparkle updates from an installed
Pilot.appwill deliver aCockpit.appbundle; worth confirming the in-place rename behavior before the next release.🤖 Generated with Claude Code