Feature: matchbox_server docker image GitHub action - #420
Feature: matchbox_server docker image GitHub action#420AgustinRamiroDiaz wants to merge 8 commits into
Conversation
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
|
Wow, thanks for this! |
|
We are already building and pushing images to the github container registry and then manually pushing to dockerhub. With this PR, we'd build the server image twice, though. Would be good if there was just one image built per version. Also not sure if continuing to push to ghcr.io is valuable or not. Maybe we should just choose one container registry, and either drop docker or ghcr? Either way, getting rid of the manual steps would be great. |
|
@johanhelsing oh I haven't seen that before, it's under the I can do whatever you think it's best. We could merge the 2 workflows into the |
|
Thanks, I think it's best to push to both registries, if not too complicated. I think the image should build on all pr runs, but only push on tags. I think the push on tag path might be broken, perhaps the workflow is not triggering on tags anymore... at least I had to do it manually last release. Thanks for working on this! |
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
@johanhelsing I think that was because tags were not taken into account in the workflow triggers. I'll fix that too in this PR
You're welcome :) |
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Login to Docker Hub | ||
| uses: docker/login-action@v3 |
There was a problem hiding this comment.
I think at least some of these steps should have:
if: startsWith(github.ref, 'refs/tags/')
Part of #372
What
Adds this github action configured for this repo
Testing done
You can see the triggers of my tests
The pushed images are here
Configuration from your side
Requires creating an access token in Docker Hub, and configuring the secret
DOCKERHUB_TOKENand the variableDOCKERHUB_USERin this repo