Bevy 0.19 migration - #556
Open
barafael wants to merge 4 commits into
Open
Conversation
Bumps bevy to 0.19, ggrs to 0.13, and bevy_ggrs to 0.22 to match. Key changes: - Remove Component derive from MatchboxSocket (Resource is now a subtrait of Component in Bevy 0.19) - Add type Out = () to Command impls (required by Bevy 0.19 Command trait) - Detach socket/server startup tasks (Task::detach returns () in Bevy 0.19) - Update bevy_ggrs example for new APIs (FontSource, FontSize, with_num_players returns Result, add_rollback -> insert)
Bump matchbox_protocol, matchbox_socket, matchbox_signaling, matchbox_server, and bevy_matchbox from 0.14.0 to 0.15.0. This release includes the upgrade to Bevy 0.19.
The socket message loop no longer panics -- and with it kills every connection of the socket -- when an outgoing send races a peer teardown (WebRTC blips, abrupt disconnects, rejoins under a new id). It drops the outgoing packet with a warning instead. Upper layers treat reliable sends as best-effort and retransmit, so dropping is safe. A data-channel on_open callback no longer panics after handshake teardown. The receiving end (the handshake-completion future) may already be gone when the channel opens mid-race; we log instead of taking the whole message loop down. Also trim the workspace to the runtime crates needed for patching (bevy_matchbox, matchbox_socket, matchbox_signaling, matchbox_protocol): drop matchbox_server and the examples/ and website/ trees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
initial bevy 0.19 port which I'm testing myself right now. AI-assisted, so don't waste your time reviewing it closely yet.
I'll comment and remove this part of the disclaimer once this is ready for detailed review!