Fix gap of upward opening dynamically created contextmenu - #302
Merged
Conversation
The helper function getLineHeight calculates the height of a contextmenu entry by mocking two entries and divide the height of the container by two. But this does not take the padding of the container into account. Padding must be substracted from the offsetHeight.
…irectly Covers the upward-menu gap fix in getLineHeight: the measured line height must be independent of the container's vertical padding. Also drops the unnecessary `globalThis.` qualifier to satisfy lint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
thank you very much @hw-df and sorry the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper function getLineHeight calculates the height of a contextmenu entry by mocking two entries and divide the height of the container by two.
But this does not take the padding of the container into account. Padding must be substracted from the offsetHeight.
Closes #301
Related #290
Related #291