fix misleading installer error when disk space/quota exceeded - #48165
Closed
Raheem54 wants to merge 1 commit into
Closed
fix misleading installer error when disk space/quota exceeded#48165Raheem54 wants to merge 1 commit into
Raheem54 wants to merge 1 commit into
Conversation
brianteeman
reviewed
Jul 30, 2026
| $this->setPath('source', $path); | ||
| } else { | ||
| $this->abort(Text::_('JLIB_INSTALLER_ABORT_NOINSTALLPATH')); | ||
| if (disk_free_space(dirname($path)) < 51200) { |
Contributor
There was a problem hiding this comment.
why 51k? You might have 5mb free but the extensions requires 7mb
Author
Contributor
|
Perhaps a more sensible check would be against the size of the file being written to temp and also ensuring that there is enough space to extract it in the temp and then copy it to the correct location |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves # .
Summary of Changes
update misleading installer error when disk space/quota exceeded by check free space before error
Testing Instructions
try to install any extension on system with full space and observe error message
Actual result BEFORE applying this Pull Request
displays: "install path does not exist"
Expected result AFTER applying this Pull Request
displays: "The filesystem is full or the user's disk quota has been exceeded."
Link to documentations
Please select:
Documentation link for guide.joomla.org:
[x ] No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed