docs: document Switch constructor - #750
Merged
Merged
Conversation
alcarraz
reviewed
Aug 11, 2026
| private boolean prefixMode; | ||
| private List<String> sortedRoutingKeys = List.of(); // kept sorted from longest to shortest | ||
|
|
||
| /** Creates the selector; configuration is supplied via {@link #setConfiguration(Configuration)}. */ |
Contributor
There was a problem hiding this comment.
The javadoc is for the cfg field. I guess the warning is because the field is Private. I think it could just be removed and document the setConfiguration method instead, or just make it a regular Java line comment.
Contributor
There was a problem hiding this comment.
Actually, I misread the javadoc, sorry for the noise, this is OK, looking up the history this was the original javadoc for the constructor, that was left misplaced by #749.
I will still take the chance to write the javadoc for setConfiguration since I'm here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the existing selector-construction Javadoc from the configuration field to the Switch constructor, making the Javadoc task warning-free.