Fix revision metadata in Git worktrees - #758
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Any Gradle build invoked from a linked Git worktree fails during task input fingerprinting because the revision task assumes
.gitis a directory and dereferences a missing.git/HEAD.Why This Change Was Made
.gitwhen it is either a directory or a worktreegitdir:pointercommondirunknown/unknownfallback for exported sourceThis uses Git's metadata files directly, without requiring the
gitexecutable or adding a dependency.User Impact
jPOS can be built normally from linked Git worktrees, and generated
revision.propertiescontains the correct branch/revision metadata. Builds from source exports without.gitcontinue to work with unknown revision metadata.Evidence
./gradlew :jpos:compileJava --no-daemonfrom a linked worktree./gradlew jpos:check --no-daemoncreateRevisionPropertyFilein an ordinary checkout, a branch worktree, a detached worktree, and a source export without.gitFixes #757