Core log kinds conform to the registered Kind vocabulary - #762
Merged
Conversation
Rename ad-hoc and uppercase LogEvent tags in core to registered kinds (status, warn, debug, send, receive, jce-provider, error, config, session-warning) and carry the type-implied kind at the audit-event emission sites: ISOServer sessions, Listen, channel connect/disconnect now log as iso-session; Q2 deploy events as deploy; Q2 start/stop/ shutdown/license audits as lifecycle; throwable audits as error. Envelope kind values and XML element names change for the affected events; no registry, API, realm or JSONL format change. Closes #761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #761. Follow-up to #759 / #760.
What
Core's own log emissions now conform to the registered
Kindvocabulary.Literal tag renames (all to kinds already registered):
SystemMonitorSystemMonitorstatusSimpleLogSource.warn(...)warningwarnISOServersession loopVetoException,ISOExceptionsession-warningISOServershutdown exceptionshutdownerrorBASE24TCPChannellength / trailer dumpsget-message-length,got-message-length,get-message-trailler,got-message-traillerdebugBCDChannel,HEXChannel,NCCChannelsend-message-lengthdebugFSDChannelfsd-channel-debugdebugLoopbackChannelloopback-send,loopback-receivesend,receiveJCESecurityModulejce-provider-cbc-mac,jce-provider-ede-macjce-providerSimpleKeyFileget-key-errorerrorDirPolldirpollerrorRealmLogFilterignored-realmsconfigType-implied kinds at the audit-event emission sites (envelope tag now comes from the payload's registered type):
ISOServersession start / endinfoiso-sessionISOServer.log(Listen)infoiso-sessionISOServer.log(ThrowableAuditLogEvent)infoerrorBaseChannel,ChannelPoolconnect / disconnectconnect,disconnectiso-sessionQ2deploy / undeploy / deploy-activityinfodeployQ2.audit()start / stop / shutdown / licenseinfolifecycleThe four BASE24TCP markers keep their former tag name as the debug payload, so the events stay distinguishable.
Not changed
Registry and API.
new LogEvent()still meansinfo. Realms.s-m-operation. JSONL format (onlykindvalues for the events above).Release note
<info>to<iso-session>,<lifecycle>and<deploy>; channel connect and disconnect go from<connect>/<disconnect>to<iso-session>(the payloadtstill says which).FilterLogListenertreats unregistered tags asinfo, so filtering of the new kinds is unchanged. Throwable audit events now carryerrorand pass awarnthreshold.SysLogListenerforwards only the tags listed in itstagsproperty. Deployments that listinfomust addiso-session,lifecycleanddeployto keep receiving those events.