Skip to content

fix(tools): increase z-index of filters drawer and detail modal to z-… - #2457

Open
Akshita-tech17 wants to merge 2 commits into
json-schema-org:mainfrom
Akshita-tech17:fix/filter-drawer-z-index
Open

fix(tools): increase z-index of filters drawer and detail modal to z-…#2457
Akshita-tech17 wants to merge 2 commits into
json-schema-org:mainfrom
Akshita-tech17:fix/filter-drawer-z-index

Conversation

@Akshita-tech17

Copy link
Copy Markdown

What kind of change does this PR introduce?

Bugfix (UI Layout Improvement)

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

N/A

Summary

This PR resolves an issue where the Tools page's Filter Drawer and Tooling Detail Modal did not overlay other page components properly because of their low z-index (z-50).

To fix this:

  • Increased the container z-index class from z-50 to z-[200] in both ToolingDetailModal.tsx and index.page.tsx.

These changes ensure both overlays display on top of all other elements correctly.

Does this PR introduce a breaking change?

No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 44ae9da

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8e9b445) to head (44ae9da).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          695       695           
  Branches       215       215           
=========================================
  Hits           695       695           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github Utkarsh-123github left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akshita-tech17
The changes you made look good.
Could you please fix this small UI issue in the same PR as well? The search bar has a border in light mode, but it’s missing in dark mode. Please add the border for dark mode too.

Thanks!

Image Image

@github-project-automation github-project-automation Bot moved this from Ready to review to Changes requested in PR - Triage Group Aug 30, 2026
@Akshita-tech17

Akshita-tech17 commented Aug 30, 2026

Copy link
Copy Markdown
Author

Hi @Utkarsh-123github! Done! I've updated the branch with the fix for the dark mode border. Let me know if everything looks good now.

Also, since I am new to open source and contributing, I'm really excited to learn more. Please keep guiding me if there is anything else I can improve. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Changes requested

Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Filters drawer has no visible close button on the Tools page

2 participants