Match the draft 5, 6 and 7 metaschema links to their actual id scheme - #2490
Open
magic-peach wants to merge 1 commit into
Open
Match the draft 5, 6 and 7 metaschema links to their actual id scheme#2490magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
The Draft-05, Draft-06 and Draft-07 pages link to their metaschema over https, but the metaschemas themselves declare id/$id with http. Draft-05 reuses the Draft-04 metaschema, which is also http. Verified each by fetching the live schema and reading its id field. Changed the displayed links to match what the schema actually declares.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 695 695
Branches 215 215
=========================================
Hits 695 695 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix (content).
Issue Number:
Screenshots/videos:
Not applicable, this only changes a URL scheme in link text and href, not layout.
If relevant, did you update the documentation?
Not applicable, this is the documentation.
Summary
The Draft-05, Draft-06 and Draft-07 pages link to their metaschema over https, but the metaschemas themselves declare id/$id with http. Draft-05 reuses the Draft-04 metaschema, which is also http. Verified each by fetching the live schema at its URL and reading the id field directly rather than assuming. Changed the displayed link text and href on all three pages to match what the schema actually declares.
Draft-2019-09 and Draft-2020-12 were checked too and are already correct, both declare https and link with https, so they needed no change.
Does this PR introduce a breaking change?
No.
Checklist