⚡ Bolt: Optimize library list query performance - #88
Conversation
Refactors `find_book_by_title_author_conn` to limit the base books table to a maximum of 200 records before joining the `book_files` table and performing the `GROUP BY` aggregate. This prevents a full table scan and excessive aggregation operations when matching candidates against very large libraries, mitigating potential N+1 bottlenecks. Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added a CTE to limit the intermediate result set in
find_book_by_title_author_conn.🎯 Why: In large libraries, failing to limit the rows before a
GROUP BYandLEFT JOINonbook_filescreates a full table scan that severely impacts performance during background tasks and auto-matching.📊 Impact: Prevents N+1 bottlenecks by bounding the inner query to 200 records prior to aggregation, bounding execution time to O(1) relative to library scale instead of O(N).
🔬 Measurement: Verify by executing large library test suites (e.g.
cargo test --manifest-path src-tauri/Cargo.toml) and observing stable execution times regardless of database scale.PR created automatically by Jules for task 9877300629532606772 started by @jspann21