Skip to content

Update heading xs line height tokens.jsonc - #3175

Open
juanfelipecr wants to merge 2 commits into
mainfrom
DSW-4227-Updated-line-height-for-heading-xs
Open

Update heading xs line height tokens.jsonc#3175
juanfelipecr wants to merge 2 commits into
mainfrom
DSW-4227-Updated-line-height-for-heading-xs

Conversation

@juanfelipecr

Copy link
Copy Markdown
Contributor

updated line height for heading-xs.
line-height-wide: changed from line-height 20 to line-height 18 and
line-height-narrow: changed from line-height 20 to line-height 16

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • If a component was added or its props were updated, I provided the necessary updates for the Figma Code Connect file

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

updated line height for heading-xs.
line-height-wide: changed from line-height 20 to line-height 18
and
line-height-narrow: changed from line-height 20 to line-height 16
@juanfelipecr
juanfelipecr requested a review from a team as a code owner September 4, 2026 08:11
@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1bfc918

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"heading-xs": {
"size--wide": "size-16",
"line-height--wide": "line-height-20",
"line-height--wide": "line-height-18",

@ashleynolan ashleynolan Sep 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think line-height-18 currently exists as a global token – would need to be added for this to output as an alias

Heading XS Wide:
Removed line height 18 and left it as line-height-20
@pie-design-system-app

Copy link
Copy Markdown
Contributor



Fails
🚫

PR Title Validation Failed

The PR title should follow the same convention used for commits, e.g.:
type(scope): TICKET-123 title where TICKET-123 is a valid ticket ID.

Note: Ticket IDs cannot be all zeros (e.g. DSW-000 is not allowed).

Current title: Update heading xs line height tokens.jsonc

🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 1bfc918

@jamieomaguire jamieomaguire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a changeset file before this can be merged and the tokens metadata change should be a part of this pull request - can perhaps help a little later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants