Draft: Add integration tests - #288
Conversation
Fixing also some unused imports on the way.
The new structure follows the model-view-controller paradigm and aims at making the code much better structured.
This is done only for commands that can work on their own.
13cd61d to
4594e80
Compare
into project directory.
3960036 to
74b5285
Compare
Increase the lowest tested python version. In python 3.10 the importlib.resources module works differently and tests fail. Thus increase to 3.12.
74b5285 to
6e332f8
Compare
|
Hey @mutlusun, thank you, this looks very reasonable. One thing to consider: I plan to extend noScribe in the direction of a client-server-architecture that can also be run on a powerful server in a local network. Several university research institutes have asked for such a feature. It would be great if you could keep that in mind when working on separating front- and backend logic. |
|
I have some experience using apache2 with a reverse proxy with a shiny for python based app like here: https://bescreen.ostendorflab.org |
|
@mutlusun @gernophil : Lets continue here: #289 |
|
I will rebase this after #282 is merged. |
|
@mutlusun I've seen you've changed this to a draft again, probably for the rebase. Take your time, no hurry. Thank you for all the work. |
|
Thanks! Yes, only for the rebase but I think this will take some time as the previous PR and this are a bit overlapping at the moment. I need to clean this up before. |
This MR is based on #282 and should be merged after it.
The goal of this MR was to add first integration tests. I refactored the code on the way to have a cleaner solution for this.
Changes:
I'm sorry for the rather big MR but I think noScribe profits from the integration tests and the started refactorings.
Best