Log the job traceback only for real errors, so a user cancel no longer shows up in the log as a crash - #338
Open
happyarts wants to merge 1 commit into
Open
Conversation
…r shows up in the log as a crash Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user cancels a running transcription, the cancel is transported out of the queue-pump loop as an exception. The job-level handler already distinguishes it from real errors (the job is counted as canceled, not failed), but it then unconditionally logged the message as an error followed by
Job error details:with a full traceback — so a deliberate cancel looked like a crash in the log file and on stdout.This splits the handler: a user cancel now logs only the cancellation message, while real errors keep the full error message and traceback exactly as before.
Observed log before the change (user cancel):
The summary at the end was already correct (canceled: 1, failed: 0); only the logging changes.
🤖 Generated with Claude Code