add AZS009: computed-only fields must not set input-only schema attributes - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rule. A computed-only field (
Computed: true, noOptional/Required) is filled from the API, soValidateFunc,MaxItems,Default,ConflictsWithand the rest of the SDK's input-only list do nothing on it. The plugin SDK'sInternalValidatealready rejects those on the field that saysComputed, but not on fields nested inside a computed-only block, not on an element schema'sValidateFunc, and notOptional/Requiredon nested fields. Those are the cases this catches, plus everything in a typed resource'sAttributes(), which azurerm forces Computed at start-up.-fixdeletes the attribute's line, or turns a nestedOptional/RequiredintoComputed. On azurerm: 35 reports, all nested or element cases, zero top-level; the fix touches 11 files and the provider builds.Also moves AZR009's
deleteLineintolib/astxasDeleteLineso both rules share it, and carries the sameskippregex fix as #43 so typos passes here.