Add browser alerts to the console - #1744
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
/kelos claude-review |
|
🤖 Kelos Task Status Task |
|
🤖 Kelos Claude Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE Findings Overview
FindingsNo blocking findings. The event gating is placed before Suggestions (optional)
Key takeaways
|
f831b83 to
2910b25
Compare
|
Addressed the current review feedback and squashed the branch to one commit,
Validation passed: |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Users currently need to watch a Session's conversation to notice when it needs input or finishes. Add an opt-in Browser alerts control in the sidebar that sends notifications for input requests and completed or failed work while the user is away from the connected Session's conversation. Clicking a notification opens that Session if it is still available in the active namespace.
The console saves the preference, requests notification permission only when the user enables alerts, and suppresses duplicate events, history replay, and interrupted work. Notification bodies use generic status text without including questions or error contents. Session refreshes dismiss alerts for deleted or replaced Sessions while preserving alerts for existing Sessions. The toggle follows the console's 44px mobile touch-target convention.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Alerts cover the connected Session while the console tab remains open. They require HTTPS or localhost and a browser that supports notifications from an open page; most mobile browsers do not support these notifications.
Validation:
make updatemake verifyenv -u CODEX_HOME -u CODEX_AUTH_JSON make testUnit tests run with
CODEX_HOMEandCODEX_AUTH_JSONunset to isolate entrypoint fixtures from the agent environment. Tests exercise notification permissions, persistence, event filtering, click targets, failure handling, and cleanup of deleted or replaced Session alerts with a mocked browser API. Failed or stale Session refreshes preserve existing alerts.Does this PR introduce a user-facing change?