Add optional video input to the chat completions input path - #63
Open
octo-patch wants to merge 1 commit into
Open
Add optional video input to the chat completions input path#63octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: the chat-completions input path builds only text and image content parts, so models that also accept video input cannot receive it.
Summary
video_urlargument togenerate_text,generate_stream_text, andstructured_response, mirroring the existingimage_urlargument.{"type": "video_url", "video_url": {"url": ...}}content part only when the caller passes a video, so text-only and image requests keep their current payload.Notes
video_urlis not passed.Checks
ruff check simplemind/providers/openai.py tests/test_input_modalities.py(all checks passed)ruff format --diff tests/test_input_modalities.py(1 file already formatted)python3 -m compileall -q simplemind tests(passed)python3 -m pytest -q tests/test_input_modalities.py tests/test_basics.py(8 passed)python3 -m pytest -q --collect-only tests(36 tests collected)