Enhance sorting logic in SessionsDataRetrieval - #1
Open
rfcmaXi wants to merge 2 commits into
Open
Conversation
Added sorting logic IP address
Author
|
While I was at it, I also fixed a small typo in SessionsDataRetrieval.php. The sorting for the "Currently logged in" column wasn't working properly and sometimes scrambled the list when clicked. This was caused by comparing the session status to the wrong variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Thank you very much for the great plugin, which we are now using in production to protect our sessions and prevent duplicate logins.
I’ve added some logic here to sort the IP addresses properly. We can tell from the IP address which of our many rooms is used. It helps to have the IP blocks grouped together.
Best regards!!!