disable stream read tests on bpf-gcc - #518
Merged
Merged
Conversation
stream_oversize and stream_partial_read load the stream skeleton without disabling stream_arena_subprog_fault. GCC emits code for that program that the verifier rejects because it dereferences R2 after treating it as a scalar. Both tests therefore fail during skeleton load, before exercising the behavior they are intended to cover. Disable them for bpf-gcc until the shared skeleton load issue is resolved. Link: kernel-patches/bpf#13411 Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_oversizeandstream_partial_readboth load the shared streamskeleton. When the BPF programs are compiled with GCC, skeleton loading
reaches
stream_arena_subprog_faultand fails verification before eithertest reaches its intended checks:
Temporarily add both top-level tests to
DENYLIST.test_progs-bpf_gcc, following the existing exclusions for theincompatible stream programs.
Observed in: