Draft: Avoid going deeper if not needed - #48
Open
lukaselmer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running out of memory when sorting a big, deep, json file. I noticed that even though I set
depthto a small number, I'm still running out of memory.The proposed performance optimization stops the recursion when the depth is reached. This should
The proposed solution is not tested (yet), that's why I marked it as a draft. I'm also not sure if it is on purpose to reverse the keys even when the depth is reached => if it's a bug, then
&& !reversecan be removed to fix the bug.@kesla what are your thoughts on this?