Revert web-async to std::sync::Mutex - #35
Merged
Merged
Conversation
Actually requires tokio_unstable.
kixelated
enabled auto-merge (squash)
February 18, 2026 20:54
kixelated
disabled auto-merge
February 18, 2026 20:54
parking_lot::Mutex doesn't implement UnwindSafe/RefUnwindSafe, which removes auto-trait impls from any type containing Lock<T>. This caused 8 semver failures in downstream crates (moq-lite, hang). Switch back to std::sync::Mutex which preserves these auto-traits. Remove the deadlock detection feature since it depended on parking_lot. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kixelated
changed the title
kixelated
enabled auto-merge (squash)
March 3, 2026 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parking_lot::Mutexwithstd::sync::Mutexin web-asyncdeadlockfeature anddeadlock.rs(depended on parking_lot)parking_lotandctordependenciesparking_lot::Mutexdoesn't implementUnwindSafe/RefUnwindSafe, which strips those auto-trait impls from any type containingLock<T>. This caused 8auto_trait_impl_removedsemver failures in downstream crates (moq-lite, hang).Test plan
cargo check --target aarch64-apple-darwinpasses🤖 Generated with Claude Code