fix(web-codecs): VideoFrame::timestamp returns f64 in web-sys 0.3.100 - #39
Merged
Conversation
web-sys 0.3.100 changed `VideoFrame::timestamp()` from `Option<f64>` to `f64`, so the `.unwrap()` no longer compiles. Drop it. Cargo.lock is gitignored, so CI resolves web-sys fresh to the latest and this breaks every PR until updated (same as the earlier 0.3.91 bump). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web-sys 0.3.100changedVideoFrame::timestamp()fromOption<f64>tof64, soweb-codecs/src/video/frame.rsno longer compiles:Fix is to drop the
.unwrap().Cargo.lockis gitignored (library convention), so CI resolvesweb-sysfresh to the latest on every run. That means this break blocks all PRs against the repo, not just one (same situation as the earlier "Update web-codecs for web-sys 0.3.91" change). Verified atweb-sys 0.3.100:cargo build/clippy -D warnings/fmt --checkall clean for web-codecs onwasm32-unknown-unknown.🤖 Generated with Claude Code