feat(spaces): space title menu with calendar submenus and config shortcuts - #575
Merged
Conversation
…and config shortcuts
The labeled calendar dropdown next to a space title becomes a regular
chevron menu (SpaceTitleMenu, renamed from CalendarMenu): calendar action
groups ("add to calendar", "add events to calendar") open as submenu
flyouts, and maintainer-tier+ viewers additionally get "configure"
(linking to the About tab) and "add view display..." (the About tab's
view-displays action as a direct shortcut, built from the view nanopub's
own action declaration so it stays in sync).
Dropdown entries now keep the body font (Inter) when the menu sits inside
a heading. nanodash.js flips a submenu flyout leftward when the viewport's
right edge lacks room. Group entry lists are defensively copied into
ArrayLists: List.of()'s CollSer serialization proxy broke restoring stored
pages (ClassCastException on ListDataProvider.list) since the entries are
also reachable through the page's component tree.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the dropdown next to a space title (formerly the labeled calendar menu) into a regular chevron menu,
SpaceTitleMenu(renamed fromCalendarMenu):gen:ViewResultActiondeclaration (template, target field,gen:isVisibleTogate), so the shortcut stays in sync if the view is superseded. The menu now also appears on event-less spaces for maintainers..actionmenu-subitem/-sublabel/-subcontent) with a right-pointing chevron and hover flyout;nanodash.jsflips the flyout leftward when the viewport's right edge lacks room (mirroring the existing dropdown repositioning)..actionmenu-contentnow pins the body font stack, so dropdown entries render in Inter instead of inheriting Martian when a menu sits inside a heading.Groupentry lists are defensively copied intoArrayLists.List.of()serializes via thejava.util.CollSerproxy, and since the entries are also reachable through the page's component tree, restoring a stored page hit aClassCastExceptionassigning the proxy toListDataProvider.list.Test plan
/space?…&tab=aboutand the publish link matching the About-tab action exactly).ClassCastException.🤖 Generated with Claude Code