fix(ios): Add missing request error handling - #5
Merged
lazarvelickovic merged 1 commit intoJun 7, 2023
Merged
lazarvelickovic merged 1 commit into
lazarvelickovic merged 1 commit into
Conversation
lazarvelickovic
marked this pull request as ready for review
May 30, 2023 16:03
sbakic
approved these changes
Jun 5, 2023
sbakic
left a comment
sbakic
left a comment
Member
There was a problem hiding this comment.
LGTM.
Can we get the before and after videos?
Member
Author
BEFORE: RPReplay_Final1686139154.MP4AFTER: RPReplay_Final1686139882.MP4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this added for
capacitor-community#224
Copied solution from this PR:
capacitor-community#225
In our case, we need it on iOS when initializing the app and the device is offline at that moment,
fetchChatsmethod is triggered but this line is not triggered at all:https://github.com/komed-health/frontend/blob/089bd98560ce0cc79b618f011a464a6939daf32d/src/app/Chat/Chat-Lobby/Shared/Services/chat-lobby.service.ts#L65
And because of that, we have a loading spinner in a chat lobby header even when the device is put back to online.