fix(renderer): stroke dashed lines separately - #92
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a36a2e196e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| !style.dashes && | ||
| !nextStyle.dashes && |
There was a problem hiding this comment.
Batch lines when dash pattern normalizes to solid
render now blocks batching whenever style.dashes is truthy, but Kothic.path treats many truthy dash values (for example [0, 0], [0, 2], or non-numeric entries) as solid by normalizing them to [] in src/renderer/path.js. In those cases, this change forces one stroke per feature even though the rendered line is solid, which regresses the “solid lines still share a stroke” behavior and can reintroduce per-feature seams/perf overhead on split geometries.
Useful? React with 👍 / 👎.
Signed-off-by: Darafei Praliaskouski <me@komzpa.net>
a36a2e1 to
d541f3e
Compare
Summary
Fixes #61.
Validation
npm test