Skip to content

fix: add rel protection to footer policy link - #855

Open
RedZapdos123 wants to merge 1 commit into
kubeedge:masterfrom
RedZapdos123:fix/footer-policy-rel-protection
Open

fix: add rel protection to footer policy link#855
RedZapdos123 wants to merge 1 commit into
kubeedge:masterfrom
RedZapdos123:fix/footer-policy-rel-protection

Conversation

@RedZapdos123

@RedZapdos123 RedZapdos123 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

Which issue(s) this PR fixes:
Fixes #853.

  • What kind of change does this PR introduce?

Bug fix.

  • What is the current behavior?

The footer policy link opens a new tab with target="_blank" but does not include rel="noopener noreferrer".

  • What is the new behavior ?

The footer policy link now keeps the same behavior and adds rel="noopener noreferrer" for the external new-tab anchor.

  • Does this PR introduce a breaking change?

No.

  • Other information:
  • Verified with npx -y yarn@1.22.22 install --frozen-lockfile.
  • Verified with npx -y -p node@20 --call "node ./node_modules/@docusaurus/core/bin/docusaurus.mjs build".
  • Verified with npx -y prettier@3.3.3 --check docusaurus.config.js.
  • Proof was checked from the generated built homepage footer anchor before and after the fix.

Before the fix:

image

After the fix:

image

Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates docusaurus.config.js by fixing a minor formatting issue and adding rel="noopener noreferrer" to an external link in the footer for security. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Footer policy link uses target="_blank" without rel protection

2 participants