Skip to content

docs: document five exposed metrics in the monitoring reference - #445

Open
yindia wants to merge 1 commit into
kubernetes-sigs:mainfrom
yindia:docs/document-missing-metrics
Open

docs: document five exposed metrics in the monitoring reference#445
yindia wants to merge 1 commit into
kubernetes-sigs:mainfrom
yindia:docs/document-missing-metrics

Conversation

@yindia

@yindia yindia commented Aug 23, 2026

Copy link
Copy Markdown

Description

Five controller metrics are registered and served on /metrics but were missing from the monitoring reference. This adds an entry for each, matching the format of the existing metrics, with the correct type, labels, and label values taken from the source.

Metrics added to docs/book/src/operations/monitoring.md:

  • node_readiness_bootstrap_duration_seconds
  • node_readiness_reconciliation_latency_seconds
  • node_readiness_nodes_by_state
  • node_readiness_condition_failures_total
  • node_readiness_rule_last_reconciliation_timestamp_seconds

Related Issue

Fixes #444

Type of Change

/kind documentation

Testing

make docs builds the mdBook with no warnings or errors.

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

NONE

Add monitoring reference entries for node_readiness_bootstrap_duration_seconds,
node_readiness_reconciliation_latency_seconds, node_readiness_nodes_by_state,
node_readiness_condition_failures_total, and
node_readiness_rule_last_reconciliation_timestamp_seconds. These metrics are
registered and served on /metrics but had no entry in monitoring.md.
@kubernetes-prow kubernetes-prow Bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 23, 2026
@netlify

netlify Bot commented Aug 23, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit 11f629f
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a8b39a27d701d0008e702e4
😎 Deploy Preview https://deploy-preview-445--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yindia
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @yindia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: five exposed metrics are missing from the monitoring reference

1 participant