ci: validate embedded GLSL shaders with glslangValidator - #16
Merged
Conversation
kxxoling
force-pushed
the
ci/glsl-validation
branch
from
August 28, 2026 02:34
142f38c to
717291c
Compare
GLSL syntax errors in Shaders.kt only surface at runtime on device (the wallpaper goes black; the only hint is a shader-compile line in logcat). Extract each Vertex/Fragment triple-quoted string and validate it with glslangValidator. Runs as a dedicated Shader Validation workflow (.github/workflows/ shader-validation.yml), fully isolated from the main CI job; current action versions (checkout@v7, setup-java@v6, setup-gradle@v6). Cache matching is strict (gradle-home-cache-strict-match), so this workflow only consumes cache entries it produced itself and stays independent of the main CI's cache lifecycle. The validator is a plain Gradle task in Kotlin - no extra interpreter beyond the JVM Gradle already runs on - and is wired into check for local runs, skipping automatically when glslangValidator is missing.
kxxoling
force-pushed
the
ci/glsl-validation
branch
from
August 28, 2026 02:40
717291c to
a18db42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLSL syntax errors in Shaders.kt only surface at runtime on device (the wallpaper goes black; the only hint is a shader-compile line in logcat). Extract each Vertex/Fragment triple-quoted string and validate it with glslangValidator.
Runs as a dedicated Shader Validation workflow (.github/workflows/ shader-validation.yml), fully isolated from the main CI job; current action versions (checkout@v7, setup-java@v6, setup-gradle@v6). The validator is a plain Gradle task in Kotlin - no extra interpreter beyond the JVM Gradle already runs on - and is wired into check for local runs, skipping automatically when glslangValidator is missing.
Also switches settings.gradle.kts from FAIL_ON_PROJECT_REPOS to PREFER_SETTINGS: repositories added by local mirror init scripts (e.g. Aliyun mirrors) otherwise fail the build outright.