feat(WhereUI): welcome users to their live region - #309
Merged
Conversation
…gion # Conflicts: # Where/WhereUI/Sources/Primary/LocationsView.swift
kyleve
commented
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Locations tab did not acknowledge when Where began counting recorded days toward the user's current region. The new card makes that transition visible and provides a direct path to planning the rest of the stay without creating a second planning workflow. The Appearance switch keeps that acknowledgement optional.
Review focus
PlannedStayEditor, remains absent when planning is disabled, and waits for the welcome exit animation before presenting the sheet.Testing
./test WhereCoreTests WhereUITests --no-generate— 1,085 tests passed../test --only 'WhereCoreTests/WherePreferencesTests' --only 'WhereUITests/YearReportModelTests' --only 'WhereUITests/LocationWelcomeModelTests' --only 'WhereUITests/SettingsSearchTests' --no-generate— 55 tests passed../test --snapshots --only 'WhereUISnapshotTests/AppearanceSettingsViewSnapshotTests' --only 'WhereUISnapshotTests/LocationsViewSnapshotTests' --record never --review --no-build --no-generate --skip-architecture— 2 tests passed; all changed references were visually reviewed across light, dark, increased-contrast, VoiceOver-annotation, and large Dynamic Type variants../swiftformat --lint./sf-symbols --lint./xcstrings --lintgit diff --check