chore(lint): vendor anti-slop oxlint plugin - #280
Open
l2ysho wants to merge 1 commit into
Open
Conversation
Add dmmulroy/anti-slop as a vendored oxlint JS plugin in tools/oxlint/anti-slop, with all 15 generic rules at "error". The Effect rule group is removed: this repo has no Effect dependency. oxlint moves 1.71.0 -> 1.79.0 and @oxlint/plugins 1.79.0 is added. The plugin API needs both packages at the same version, and @oxlint/plugins does not publish anything below 1.73.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Vendors dmmulroy/anti-slop as an oxlint JS plugin at
tools/oxlint/anti-slop/, with all 15 generic rules enabled aterror..oxlintrc.json: addsjsPlugins, the 15 rules, and ignore patterns for.agent/**,.agents/**,.claude/**,tools/oxlint/anti-slop/**.package.json:oxlint1.71.0 -> 1.79.0, adds@oxlint/plugins1.79.0.effect/rule group is deleted; this repo has no Effect dependency.Why the oxlint bump
The JS plugin API needs
oxlintand@oxlint/pluginsat the same version, and@oxlint/pluginspublishes nothing below 1.73.0. 1.71.0 could not load the plugin at all.Reviewer notes
CI lint will fail on this branch. The new rules report 21 errors in existing source. They are not fixed here, because installing rules and migrating code are separate changes:
no-runtime-typeofsrc/core.ts,src/parsePdf.ts,src/resolveInput.ts, 2 testsrequire-safety-comment-for-type-assertionsrc/core.ts,src/getPdfMetadata.tsno-unknown-parameterssrc/getPdfMetadata.tsno-unsafe-dictionary-typesrc/getPdfMetadata.tsThe 8
SAFETY:comments are mechanical.no-runtime-typeofis not:resolveInputbranches onstring | Buffer | Streamby design, so it needs either a discriminated input type or a per-file exception. Decide before merge.pnpm typecheckpasses. The vendored plugin is outsidetsconfig.jsoninclude.Upstream expects the vendored copy to be edited locally, not tracked as a fixed dependency.
🤖 Generated with Claude Code