fix: lanyard redirect - #869
Open
juliankepka wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the /setup page to ensure the dynamically loaded Lanyard component is re-mounted across navigation/redirect transitions, preventing stale WebGL/physics state from persisting when the route changes.
Changes:
- Track the current route pathname and force a
Lanyardremount by changing its Reactkey. - Reorder/setup hooks to support the remount behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+38
| const pathname = usePathname(); | ||
| const [lanyardKey, setLanyardKey] = useState(0); | ||
| const isFirstRender = useRef(true); | ||
|
|
||
| useEffect(() => { |
timbastin
requested changes
Aug 4, 2026
timbastin
left a comment
timbastin
left a comment
Member
There was a problem hiding this comment.
I think copilot is right :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evidence.mov