Fix/diagnostics sentinel - #19
Merged
Merged
Conversation
The diagnostics() docstring promises None for temperature locations the camera model does not support, but the TS-IR returns the raw ADC-floor sentinel (-138.30128479003906 C) for absent thermistors instead of rejecting the read, so the bogus value leaked through. Detect that exact sentinel and map it to None so the contract holds. Closes #16.
…tinel # Conflicts: # docs/source/changelog.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes diagnostics() returning a junk -138.3 sentinel for temperature
sensors this camera model doesn't have. The docs say those come back as
None; now they actually do. A real reading never hits that exact value,
so genuine temperatures are untouched.
Closes #16