fix(autocoder): fix-loop-gate BLOCKING set omits blocked and awaiting-integration - #128
Merged
Conversation
…-integration fix-loop-gate.sh's classify() excludes needs-approval/needs-design/ needs-clarification/too-complex/future/decomposed from the claimable pool, but not blocked or awaiting-integration -- even though /fix's own candidate-selection filter (fix.md) treats all eight as the same class of blocking label. A correctly-blocked issue (carrying only blocked, with none of the other six) re-enters the claimable pool every gate tick and gets re-selected forever, since nothing else distinguishes it from real work. Reproduced live: an athena2 issue labeled blocked (design fork resolved by the operator, but explicitly gated on two still-open prerequisite issues) was re-selected as FIX work on three consecutive gate ticks. Verified against the actual script (not a reimplementation) by stubbing issue_list/issue_claim/issue_update and running fix-loop-gate.sh directly against three synthetic issue sets: a blocked-only P1 (expect IDLE), a blocked P1 alongside a claimable P2 (expect the P2, not the blocked issue), and an awaiting-integration-only P1 (expect IDLE). All three matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix-loop-gate.sh's
classify()BLOCKING set excludes needs-approval/needs-design/needs-clarification/too-complex/future/decomposed from the claimable pool, but notblockedorawaiting-integration— even though/fix's own candidate-selection filter (fix.md) treats all eight as the same class of blocking label. A correctly-blockedissue re-enters the claimable pool every gate tick and gets re-selected forever.Reproduced live: an athena2 issue labeled
blocked(design fork resolved by the operator, but explicitly gated on two still-open prerequisite issues) was re-selected as FIX work on three consecutive gate ticks.Verified against the actual script (stubbed
issue_list/issue_claim/issue_update, ranfix-loop-gate.shdirectly) across three synthetic issue sets: blocked-only P1 → IDLE, blocked P1 + claimable P2 → picks the P2, awaiting-integration-only P1 → IDLE. All matched expectations.