feat(l1): add eth_getHeaderByHash and eth_getHeaderByNumber - #7247
Draft
MysticRyuujin wants to merge 1 commit into
Draft
feat(l1): add eth_getHeaderByHash and eth_getHeaderByNumber#7247MysticRyuujin wants to merge 1 commit into
MysticRyuujin wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
external-contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
eth_getHeaderByHashandeth_getHeaderByNumber, implementing the spec proposed in ethereum/execution-apis#877 (ethereum/execution-apis#874). geth, Nethermind, and reth already serve these methods.The result is the consensus header plus the derived
hash, with nosize,totalDifficulty, or body fields. The result isnullfor an unknown block, for thependingtag (the spec diverges fromresolve_block_number's latest fallback here), and for an unresolvablesafeorfinalizedtag.BlockHeaderserialization now skipsbaseFeePerGas,withdrawalsRoot, andparentBeaconBlockRootwhen absent, matching the struct's other optional fork fields. The spec requires pre-fork fields to be omitted rather thannull, and this also alignseth_getBlockBy*responses with geth, which omits them. Deserialization is unchanged.Full workspace
cargo checkpasses;ethrex-commonandethrex-rpctest suites pass, including a new test covering the header shape, the by-hash round trip, and the three null cases.