Label EIP-8312 UTXO frames in the frame command - #247
Open
ilitteri wants to merge 1 commit into
Open
Conversation
`rex frame inspect` rendered a UTXO frame as RESERVED, because the mode table stops at POST_TX. Verified against a real transaction on a devnet with EIP-8312 active: the frame now reads UTXO, and the self-funded payer is already detected correctly by the existing payer logic. Mode 5 rather than the draft's 3: EIP-7906 had already taken 3 for POST_TX upstream, and renumbering a mode that has live history is worse than diverging from a draft. 4 stays reserved for EIP-8288. This is the label only. Decoding the spend payload for display needs ethrex_common::types::Spend, and this branch pins ethrex at hegota-devnet, so that half unblocks when EIP-8312 merges there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rex frame inspectrendered a UTXO frame asRESERVED, because the mode table stops at POST_TX. EIP-8312 has now landed on ethrex'shegota-devnet, which this branch tracks.Description
Adds
MODE_UTXO = 5and5 => "UTXO"tomode_name, plus the module header's mode list.Mode 5 rather than the draft's 3: EIP-7906 already holds 3 for POST_TX upstream, and renumbering a mode with live history is worse than diverging from a draft. 4 stays reserved for EIP-8288.
Label only. Decoding the spend payload for display needs
ethrex_common::types::Spend; that is now available on the pinned branch and is a natural follow-up.How to Test
Against a devnet with EIP-8312 active:
Verified against a real transaction (block 4711 of a Hegotá-config devnet): the frame read
RESERVEDbefore this change andUTXOafter. The self-funded payer is already reported correctly by the existing payer logic.