feat(masters): prev/next navigation (DocPager) on master detail pages - #9
Merged
Conversation
DocPager gains kind="master": pages through /masters/{type} in the list's
order via a new GET /masters/{type}/{name}/adjacent keyset endpoint (name
ASC, include_disabled defaults true for 1:1 stepping with the list). The
master list stashes its URL in a master:{type} context so Esc/u returns to
the exact page. Also gives the master list endpoint a deterministic ORDER BY
name — it had none, so Postgres OFFSET pagination could repeat/skip rows.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Masters (Customer / Supplier / Item / Warehouse / Company + plugin-registered ones) get the same ‹ / › + keyboard navigation documents got in 0.6.4.
GET /masters/{type}/{name}/adjacent— keyset prev/next in the list's order (name ASC);include_disableddefaults true to step 1:1 with the list (which shows disabled rows).DocPager kind="master"— same component, /masters paths, ownmaster:{type}list-context namespace; master list stashes its URL so Esc/ureturns to the exact page.ORDER BY name.tests/test_adjacent.py(middle/ends, disabled parity, list order, 404).🤖 Generated with Claude Code