Rebuild the image on Debian bookworm and check it in CI - #10
Merged
Conversation
Debian jessie went end-of-life and its suites moved to archive.debian.org, so `apt-get update` 404'd and the image could not be built at all. `libappindicator1` is gone from current Debian too. Rather than track the client's dependencies by hand, install the verified .deb through apt and let it resolve them — it pulls libayatana-appindicator3-1 today. That also drops the `dpkg -i` followed by `apt-get install -f` repair dance.
Restores what Travis used to do and what the projen migration could not carry over while the build was broken: build the image, then run `keybase status` against it to prove the client actually starts.
Backslash continuations forced a choice between the blank lines that separate the steps and a NoEmptyContinuation warning on every build. A heredoc needs neither: the steps are plain shell, so the blank lines and comments stand on their own. `set -eux` keeps the fail-fast the `&&` chain used to provide, and traces the signed-package install in build logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker build .has been failing outright:buildpack-deps:jessie-curlisDebian 8, whose suites moved to
archive.debian.orgyears ago, soapt-get update404s before anything else runs.Moves the base to
buildpack-deps:bookworm-curl.libappindicator1is gonefrom current Debian, so rather than name the client's dependencies by hand the
verified
.debis now installed through apt and apt resolves them — it pullslibayatana-appindicator3-1today. That also removes thedpkg -i/apt-get install -frepair dance. The signing-key verification is untouched.With the build working again, the
Imageworkflow restores what Travis used todo and #8 could not carry over: build the image, then run
keybase statusagainst it.
Verified locally — clean build with no Dockerfile warnings,
keybase statusexits 0 on Keybase 6.6.3, and the container still runs as
keybase(uid/gid1000) in
/home/keybasewithbashas the default command.Closes #7