fix(server): wait for launchd shutdown safely - #56
Merged
Conversation
Owner
Author
|
@codex review |
2 tasks
(cherry picked from commit 7c5adc4)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23904533ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lastobelus
force-pushed
the
port/upstream/launchd-lifecycle
branch
from
August 22, 2026 05:40
2390453 to
f52d715
Compare
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
lastobelus
added a commit
that referenced
this pull request
Aug 23, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
lastobelus
added a commit
that referenced
this pull request
Aug 23, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
lastobelus
added a commit
that referenced
this pull request
Aug 24, 2026
LastCode inherits the same macOS background-service lifecycle race as upstream: `launchctl bootout` can return before the old job finishes draining, while the prior unsupported `--wait` form and optional-error handling can let reinstall proceed without proving the job is gone. This is the patch-identical LastCode port of [upstream PR pingdotgg#7874](pingdotgg#7874), from upstream commit [`7c5adc45ea3ee7456e04339430c2433e3486ffd7`](7c5adc4). It uses supported `launchctl bootout`, polls the exact service with `launchctl print` until launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping. Provenance: - upstream commit: `7c5adc45ea3ee7456e04339430c2433e3486ffd7` - stable patch ID: `e5e07203e79b88a6051cc6eea2159118e4486604` - LastCode port commit: `f52d715a97460fca99afaebc522788a85a8ae1c0` Progresses #39. Validation: - 21 focused boot-service tests - server typecheck - targeted lint, formatting, and diff checks - guarded `pnpm lastcode:ci:quick` pre-push gate Implemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastCode inherits the same macOS background-service lifecycle race as upstream:
launchctl bootoutcan return before the old job finishes draining, while the prior unsupported--waitform and optional-error handling can let reinstall proceed without proving the job is gone.This is the patch-identical LastCode port of upstream PR #7874, from upstream commit
7c5adc45ea3ee7456e04339430c2433e3486ffd7. It uses supportedlaunchctl bootout, polls the exact service withlaunchctl printuntil launchd confirms absence, and fails closed on timeout, permission, domain, or unexpected-output errors before enabling and bootstrapping.Provenance:
7c5adc45ea3ee7456e04339430c2433e3486ffd7e5e07203e79b88a6051cc6eea2159118e4486604f52d715a97460fca99afaebc522788a85a8ae1c0Progresses #39.
Validation:
pnpm lastcode:ci:quickpre-push gateImplemented by OpenAI Codex (GPT-5.6) in the T3 Code Codex harness.