feat(lastcode): commit remote update trials - #66
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2d7a3af5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
50850d4 to
a71f73a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 201924a116
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
201924a to
e4034f3
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4034f3570
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71a87f7dc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c124e6bac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await executor.startPriorService(journal); | ||
| return transition(store, journal, "rolled-back", { rollbackReason: reason }); | ||
| const rolledBack = transition(store, journal, "rolled-back", { rollbackReason: reason }); | ||
| await executor.startPriorService(rolledBack); |
There was a problem hiding this comment.
When the first upgrade containing this commit times out, restoreDatabase restores a snapshot where the request is still claimed, and this line then launches the previous app. That previous binary does not contain the newly added readUpdateActivationRollback startup transition—the parent implementation treats every non-cancelled intent as closed—so it keeps admission closed and rejects cancellation and subsequent drains indefinitely. Fresh evidence beyond the resolved thread is that rollback crosses a binary-version boundary, while the proposed recovery exists only in the discarded candidate; clear the claim through a mechanism available before launching the previous version.
AGENTS.md reference: AGENTS.md:L73-L73
Useful? React with 👍 / 👎.
|
Closing without merge after an architecture correction. The trial/candidate/remote-commit protocol adds more failure surface than the update it protects, and final review exposed a cross-version rollback bridge requirement that confirms the concern. We are replacing this with a simple idle → backup → install → normal restart flow, with rollback only after an actual startup failure. The reviewed branch is preserved for reference; none of this trial protocol will ship. |
1 participant
The activation helper can launch a candidate server in trial mode, but the server had no matching authenticated commit endpoint and could not durably reopen work admission after the helper observed a successful trial.
This adds the exact trial identity and commit RPC contract, keeps trial admission closed until the matching durable drain is claimed and the helper's exact commit record is atomically published, and reloads that record after a server restart so retries remain idempotent. It preserves the merged pending-turn and terminal blocker behavior and adds no UI, scheduling, or activation orchestration.
The server consumes the helper's existing
LASTCODE_ACTIVATION_*environment values and writes its existingruntime/activation/<requestId>/commit.jsonschema. Mismatched records fail closed.Validation:
Implemented with GPT-5 Codex in LastCode.