Skip to content

ci: authenticate SSE contract test downloads with GITHUB_TOKEN - #144

Merged
kinyoklion merged 2 commits into
mainfrom
devin/1785430143-contract-tests-token
Jul 31, 2026
Merged

ci: authenticate SSE contract test downloads with GITHUB_TOKEN#144
kinyoklion merged 2 commits into
mainfrom
devin/1785430143-contract-tests-token

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Contract test downloads were fully unauthenticated, so CI is subject to the shared-runner anonymous GitHub API rate limit. This already broke main: the 2026-07-22 run of CI (hyper-rustls-native-roots) failed with

GitHub token:  not provided (API requests may be rate-limited)
HTTP response: HTTP/2 403
Rate limit remaining: 0

(https://github.com/launchdarkly/rust-eventsource-client/actions/runs/29951809080)

.github/actions/ci now runs the contract tests through the standardized launchdarkly/gh-actions/actions/contract-tests action (same setup as swift-eventsource) instead of make run-contract-tests, with a new optional token input wired to secrets.GITHUB_TOKEN from ci.yml, release-please.yml, and manual-publish.yml. The action authenticates both the downloader fetch and the downloader's releases-API calls.

-    - name: Run contract tests
-      run: CARGO_FLAGS="..." make run-contract-tests
+    - name: Run contract tests
+      uses: launchdarkly/gh-actions/actions/contract-tests@contract-tests-v1.3.0
+      with:
+        repo: sse-contract-tests
+        branch: main
+        version: v2
+        token: ${{ inputs.token }}
+        test_service_port: '8080'
+        debug_logging: 'true'
+        enable_persistence_tests: 'false'

The Makefile target is unchanged and still available for local runs.

Link to Devin session: https://app.devin.ai/sessions/bbaa402957474f3ab30fe102ed0316e2

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot requested a review from a team as a code owner July 30, 2026 16:49
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Comment thread .github/actions/ci/action.yml
@kinyoklion
kinyoklion self-requested a review July 31, 2026 16:29
@kinyoklion
kinyoklion merged commit 7e88486 into main Jul 31, 2026
11 checks passed
@kinyoklion
kinyoklion deleted the devin/1785430143-contract-tests-token branch July 31, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants