ci: authenticate SSE contract test downloads with GITHUB_TOKEN - #144
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
approved these changes
Jul 30, 2026
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
kinyoklion
reviewed
Jul 31, 2026
keelerm84
approved these changes
Jul 31, 2026
kinyoklion
self-requested a review
July 31, 2026 16:29
kinyoklion
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract test downloads were fully unauthenticated, so CI is subject to the shared-runner anonymous GitHub API rate limit. This already broke
main: the 2026-07-22 run ofCI (hyper-rustls-native-roots)failed with(https://github.com/launchdarkly/rust-eventsource-client/actions/runs/29951809080)
.github/actions/cinow runs the contract tests through the standardizedlaunchdarkly/gh-actions/actions/contract-testsaction (same setup asswift-eventsource) instead ofmake run-contract-tests, with a new optionaltokeninput wired tosecrets.GITHUB_TOKENfromci.yml,release-please.yml, andmanual-publish.yml. The action authenticates both the downloader fetch and the downloader's releases-API calls.The
Makefiletarget is unchanged and still available for local runs.Link to Devin session: https://app.devin.ai/sessions/bbaa402957474f3ab30fe102ed0316e2